-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mirror: Partial atmos refactor #312
Mirror: Partial atmos refactor #312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm sure VM can review this
I had to double check that my own rework to Space Wind was still compatible with this, and luckily it is since I touched a function that isn't touched by this PR. The two of these combined will hopefully be an extremely significant improvement in atmos performance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code is quite well made. It still isn't a theoretically perfect atmos, but it this PR represents several substantial improvements to performance into an otherwise very poorly performing system. I am excited to eventually try running this with my Space Wind Rework.
This PR introduced a bug that was patched in space-wizards/space-station-14#26441. We should either modify this PR to include the fix, or merge the fix PR at the same time, so downstreams don't get stuck with bugged atmos for a few days. |
Yep, thanks for the reminder about this. Let's not merge this until I also am ready to immediately afterwards merge space-wizards/space-station-14#26441 |
I need this merged before I can finish the extremely urgent engine PR. I'll include the fixes for this in the engine PR... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't have the time to look over this in detail, but it looks fine.
Mirror of PR #22521: Partial atmos refactor from space-wizards/space-station-14
18a35e7e83b2b71ee84b054d44d9ed5e595dd618
PR opened by ElectroJr at 2023-12-15 03:45:42 UTC
PR changed 43 files with 891 additions and 635 deletions.
The PR had the following labels:
Original Body